Skip to content

Conversation

@hwangdae
Copy link
Collaborator

@hwangdae hwangdae commented Sep 5, 2025

작업 내용

문제점 및 어려움

해결 방안

공유 사항

Summary by CodeRabbit

  • Bug Fixes
    • Account number formatting now preserves all digits after bank-specific grouping, preventing truncated displays in the UI and exports.
    • Order creation and order detail requests are more reliable with per-request authentication, reducing intermittent errors during checkout and when viewing current orders.
    • No changes required from users; existing flows continue to work as before.

@coderabbitai
Copy link

coderabbitai bot commented Sep 5, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The API layer in apps/nowait-user/src/api/order.ts was refactored to remove a shared axios instance and switch to direct axios calls with explicit URLs and per-call credentials for two endpoints. apps/nowait-user/src/utils/accountFormat.ts adds a post-loop step to append any remaining account-number digits.

Changes

Cohort / File(s) Summary
API axios usage refactor
apps/nowait-user/src/api/order.ts
Removed shared axios instance; createOrder and getOrderDetails now call axios with ${API_URI} absolute URLs and { withCredentials: true }. getStorePayments path remains unchanged in this diff. Public signatures unchanged.
Account number formatting edge-case fix
apps/nowait-user/src/utils/accountFormat.ts
After applying bank-specific segments, any leftover digits (if start < accountNumber.length) are appended as a final segment. No signature changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant U as User
  participant A as Nowait User App
  participant X as Axios
  participant S as API Server

  rect rgb(230,245,255)
    note over A,X: New: direct axios with per-call credentials
    U->>A: Place order
    A->>X: POST ${API_URI}/orders/create/{publicCode}/{tableId}\nwithCredentials: true
    X->>S: HTTP POST (cookie/session)
    S-->>X: 201 Created / Order data
    X-->>A: Response
    A-->>U: Show order confirmation
  end

  rect rgb(240,255,240)
    U->>A: View order details
    A->>X: GET ${API_URI}/orders/items/{publicCode}/{tableId}\nwithCredentials: true
    X->>S: HTTP GET (cookie/session)
    S-->>X: 200 OK / Items
    X-->>A: Response
    A-->>U: Render order items
  end

  opt Unchanged path
    note over A: getStorePayments call path unchanged in this diff
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • merge to main #376 — Also refactors createOrder and getOrderDetails in the same file to change axios usage, indicating overlapping concerns.
  • feat: 주문 API 수정 #442 — Modifies how the API base URL is applied for createOrder and getOrderDetails, closely matching this refactor.
  • merge to main #351 — Switches to absolute API_URI construction for the same functions, directly related to this change.

Suggested reviewers

  • dgKim1
  • oriNuguri25

Poem

I hop through code with whiskers keen,
Snipping shared threads, keeping calls clean.
Cookies ride with orders, neat and tight,
Digits aligned—no tail out of sight.
Two files trimmed, the garden’s in tune—
Carrots, commits, and a shipping moon. 🥕🌙


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3f59b33 and 5633bd2.

📒 Files selected for processing (2)
  • apps/nowait-user/src/api/order.ts (2 hunks)
  • apps/nowait-user/src/utils/accountFormat.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@hwangdae hwangdae merged commit 7079ba0 into main Sep 5, 2025
2 of 3 checks passed
@github-actions github-actions bot requested a review from dgKim1 September 5, 2025 02:33
This was referenced Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants